Skip to content

WIP: HTML API: Add support for H1-H6 elements in HTML Processor #5535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmsnell wants to merge 13 commits into from
Closed

WIP: HTML API: Add support for H1-H6 elements in HTML Processor #5535

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8a2a4f6
WIP: HTML API: Add support for H1-H6 elements in HTML Processor
dmsnell Oct 19, 2023
8d2f232
Add more tests verifying that the H1-H6 elements close opened heading…
dmsnell Oct 20, 2023
f93ef13
Add positive identification tests
dmsnell Oct 20, 2023
6b45967
Move class constant into Tag Processor, match with it, and add tests
dmsnell Nov 16, 2023
da446c9
Remove the class constant to defer design questions for later.
dmsnell Dec 13, 2023
c1a880f
fixup! Remove the class constant to defer design questions for later.
dmsnell Dec 13, 2023
7e9439e
Add ticket reference
dmsnell Dec 13, 2023
e0d370c
Move H1 - H6 tests into their own semantic rules file.
dmsnell Dec 13, 2023
ed98e7c
Illustrate more edge cases for H1 - H6 in the breadcrumb tests.
dmsnell Dec 13, 2023
bf7a132
fixup! Illustrate more edge cases for H1 - H6 in the breadcrumb tests.
dmsnell Dec 13, 2023
4b8989a
fixup! fixup! Illustrate more edge cases for H1 - H6 in the breadcrum…
dmsnell Dec 13, 2023
6400821
fixup! fixup! fixup! Illustrate more edge cases for H1 - H6 in the br…
dmsnell Dec 13, 2023
4772a7d
Add missing test @covers and @ticket number
dmsnell Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Illustrate more edge cases for H1 - H6 in the breadcrumb tests.
  • Loading branch information
@dmsnell
dmsnell committed Dec 13, 2023
commit ed98e7c3dad9807b21c577ddd97017f9c32d5487
6 changes: 6 additions & 0 deletions tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,14 @@ public function data_html_target_with_breadcrumbs() {
),
'MAIN inside MAIN inside SPAN' => array( '<span><main><main target>', array( 'HTML', 'BODY', 'SPAN', 'MAIN', 'MAIN' ), 1 ),
'MAIN next to unclosed P' => array( '<p><main target>', array( 'HTML', 'BODY', 'MAIN' ), 1 ),

// H1 - H6 close out _any_ H1 - H6 when encountering _any_ of H1 - H6, making this section surprising.
'EM inside H3 after unclosed P' => array( '<p><h3><em target>Important Message</em></h3>', array( 'HTML', 'BODY', 'H3', 'EM' ), 1 ),
'H4 after H2' => array( '<h2>Major</h2><h4 target>Minor</h4>', array( 'HTML', 'BODY', 'H4' ), 1 ),
'H4 after unclosed H2' => array( '<h2>Major<h4 target>Minor</h3>', array( 'HTML', 'BODY', 'H4' ), 1 ),
'H4 inside H2' => array( '<h2><span>Major<h4 target>Minor</h3></span>', array( 'HTML', 'BODY', 'H2', 'SPAN', 'H4' ), 1 ),
'H5 after unclosed H4 inside H2' => array( '<h2><span>Major<h4>Minor</span></h3><h5 target>', array( 'HTML', 'BODY', 'H2', 'SPAN', 'H5' ), 1 ),
'H5 after H4 inside H2' => array( '<h2><span>Major<h4>Minor</h4></span></h3><h5 target>', array( 'HTML', 'BODY', 'H5' ), 1 ),
);
}

Expand Down