Skip to content

Block Types: Add metadata global attribute #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ockham wants to merge 7 commits into from
+28 −10
Closed

Block Types: Add metadata global attribute #5608

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b3bd68
Block Types: Add metadata global attribute
ockham Nov 1, 2023
37468ae
Attempt to fix tests
ockham Nov 2, 2023
7c95590
Trailing comma
ockham Nov 2, 2023
e372252
Add ticket references to tests
ockham Nov 2, 2023
5e9d4e3
Whitespace
ockham Nov 2, 2023
95edef8
Add note about lock attribute in PHPDoc.
ockham Nov 6, 2023
c9d8c08
Rephrase PHPDoc a bit
ockham Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Whitespace
  • Loading branch information
@ockham
ockham committed Nov 2, 2023
commit 5e9d4e36adc4851885e20ce88ef2a8758dd9f8c7
2 changes: 1 addition & 1 deletion tests/phpunit/tests/blocks/wpBlockType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public function test_core_attributes_matches_custom() {
'core/fake',
array(
'attributes' => array(
'lock' => array(
'lock' => array(
'type' => 'string',
),
'metadata' => array(
Expand Down