Skip to content

Revisions Controller: return single revision only when it matches the parent id #5655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 8 commits into from
Closed

Revisions Controller: return single revision only when it matches the parent id #5655

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f6f8e3f
Adding some tests to check whether get_item can return a revision who…
ramonjd Nov 10, 2023
6fdc982
Add a condition to get_item that checks the revision parent id agains…
ramonjd Nov 13, 2023
83ddc64
Coerce types
ramonjd Nov 13, 2023
f8bf0da
Remove unused var in test
ramonjd Nov 13, 2023
6d489eb
Apply suggestions from code review
ramonjd Nov 19, 2023
ff84ef6
Changed duped error code
ramonjd Dec 20, 2023
c5f48bd
Genericize error message and create a test to ensure the correct pare…
ramonjd Dec 21, 2023
139f6ca
Remove specific mention of "post" to discern between other post types…
ramonjd Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused var in test
  • Loading branch information
@ramonjd
ramonjd committed Nov 13, 2023
commit f8bf0daa1acfa68f2b421cfd6149fb9acccd41c6
1 change: 0 additions & 1 deletion tests/phpunit/tests/rest-api/rest-revisions-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ class WP_Test_REST_Revisions_Controller extends WP_Test_REST_Controller_Testcase
private $revision_id2;
private $revision_3;
private $revision_id3;
private $revision_2_1;
private $revision_2_1_id;

public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
Expand Down