Skip to content

Block Hooks: Persist information about ignoredHookedBlocks in anchor block metadata #5712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ockham wants to merge 19 commits into from
+114 −18
Closed

Block Hooks: Persist information about ignoredHookedBlocks in anchor block metadata #5712

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c74cdb2
Extract get_hooked_block_markup function
ockham Nov 28, 2023
552c66e
Set ignoredHookedBlocks metadata
ockham Nov 28, 2023
498dcf2
Rewrite a bit
ockham Nov 28, 2023
450c05f
Rewrite a bit more
ockham Nov 28, 2023
bef2301
Add ticket PHPDoc
ockham Nov 28, 2023
061cbd6
Inject hooked blocks into modified templates and parts
ockham Nov 28, 2023
acbd7f2
Relax test assertion a bit
ockham Nov 28, 2023
9e22a87
Get tests to pass
ockham Nov 28, 2023
ca6b474
Fix test
ockham Nov 28, 2023
3ad8dce
Relax tests
ockham Nov 28, 2023
df1fc75
Add some assertions for ignoredHookedBlocks
ockham Nov 28, 2023
9339ea2
Rename test
ockham Nov 28, 2023
5289f74
Add PHPDoc
ockham Nov 28, 2023
7dc3dfa
Tabs vs spaces
ockham Nov 28, 2023
dc35659
Missing .php file extension :facepalm:
ockham Nov 29, 2023
ef73917
Add test case
ockham Nov 29, 2023
41c2f1c
Coding Standards
ockham Nov 30, 2023
f3dbb7a
Revert "Inject hooked blocks into modified templates and parts"
ockham Dec 4, 2023
f4379e1
Mark get_hooked_block_markup() as private
ockham Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Mark get_hooked_block_markup() as private
  • Loading branch information
@ockham
ockham committed Dec 4, 2023
commit f4379e1d2a8cb9812f00fc51e7d8c5ff12f253bf
3 changes: 3 additions & 0 deletions src/wp-includes/blocks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,10 @@ function get_hooked_blocks() {
* If the anchor block has already been processed, and the given hooked block type is in the list
* of ignored hooked blocks, an empty string is returned.
*
Copy link
Member

@gziolo gziolo Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other similar utilities, should it be marked as private, too?

Copy link
Contributor Author

@ockham ockham Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in f4379e1.

* This function is meant for internal use only.
*
* @since 6.5.0
* @access private
*
* @param array $anchor_block The anchor block. Passed by reference.
* @param string $hooked_block_type The name of the hooked block type.
Expand Down