Skip to content

HTML API: Add explicit handling or failure for all tags #5762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 18 commits into from
Closed

HTML API: Add explicit handling or failure for all tags #5762

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f35453b
Add throw on every special element
sirreal Dec 13, 2023
dbf5db8
Remove handled tags
sirreal Dec 13, 2023
1e92ec9
Rework to use tag name
sirreal Dec 13, 2023
31abb43
Add tests
sirreal Dec 13, 2023
2eb3c97
Remove H1-H6 tests and handling (now supported)
sirreal Dec 13, 2023
ade089e
Add note mentioning test
sirreal Dec 13, 2023
2a8fc46
Add support for "any other tag" categories in IN BODY
dmsnell Dec 18, 2023
eb99542
Update more tests, more checks, add SARCASM
dmsnell Dec 18, 2023
7e8eb4c
WPCS
dmsnell Dec 19, 2023
ccc297d
Better data source descriptions
sirreal Dec 22, 2023
b20806a
Close tags so processing doesn't pause
sirreal Dec 22, 2023
556f3cf
Fix bugs uncovered by tests
dmsnell Dec 18, 2023
2cab6cf
Refactor closing tag loop, eliminate goto
dmsnell Dec 22, 2023
98c46e9
Undo whitespace change in phpcs rules
dmsnell Dec 22, 2023
620bdec
Update comments, remove redundant code.
dmsnell Dec 22, 2023
a98f30b
Add newly-supported elements to docblock, fix typo in tests.
dmsnell Dec 22, 2023
9f9ce0d
fixup! Add newly-supported elements to docblock, fix typo in tests.
dmsnell Dec 22, 2023
3f9670a
Update docblock lints and re-add MathML and SVG comments.
dmsnell Dec 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WPCS
  • Loading branch information
@dmsnell @sirreal
dmsnell authored and sirreal committed Dec 22, 2023
commit 7e8eb4cfb8b18cf4fe7753d5cef8742a41925df2
11 changes: 10 additions & 1 deletion phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
#############################################################################
SELECTIVE EXCLUSIONS
Exclude specific files for specific sniffs and/or exclude sub-groups in sniffs.

These exclusions are listed ordered by alphabetic sniff name.
#############################################################################
-->
Expand All @@ -250,6 +250,15 @@
<exclude-pattern>/wp-tests-config-sample\.php</exclude-pattern>
</rule>

<!-- Exclude forbidding goto in the HTML Processor, which mimics algorithms that are written
this way in the HTML specification, and these particular algorithms are complex and
highly imperative. Avoiding the goto introduces a number of risks that could make it
more difficult to maintain the relationship to the standard, lead to subtle differences
in the parsing, and distance the code from its standard. -->
<rule ref="Generic.PHP.DiscourageGoto.Found">
<exclude-pattern>/wp-includes/html-api/class-wp-html-processor\.php</exclude-pattern>
</rule>

<!-- Exclude sample config from modernization to prevent breaking CI workflows based on WP-CLI scaffold.
See: https://core.trac.wordpress.org/ticket/48082#comment:16 -->
<rule ref="Modernize.FunctionCalls.Dirname.FileConstant">
Expand Down
2 changes: 1 addition & 1 deletion tests/phpunit/tests/html-api/wpHtmlProcessorBreadcrumbs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public function data_single_tag_of_supported_elements() {
'METER',
'MULTICOL', // Deprecated
'NAV',
'NEXTID',// Deprecated
'NEXTID', // Deprecated
'OUTPUT',
'P',
'PICTURE',
Expand Down