Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
actions/setup-node does not currently support aliases like LTS
  • Loading branch information
desrosj committed Oct 15, 2020
commit d00996080f91fd4ffa83e0d973aefd5be9970682
8 changes: 2 additions & 6 deletions .github/workflows/coding-standards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,8 @@ jobs:
#
# Performs the following steps:
# - Checks out the repository.
# - Reads the desired version of NodeJS from the .nvmrc file.
# - Logs debug information about the runner container.
# - Installs the desired NodeJS version.
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
# - Sets up caching for NPM.
# - Logs updated debug information.
# _ Installs NPM dependencies.
Expand All @@ -90,9 +89,6 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v2

- name: Check the desired version of NodeJS
run: echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_ENV

- name: Log debug information
run: |
npm --version
Expand All @@ -103,7 +99,7 @@ jobs:
- name: Install NodeJS
uses: actions/setup-node@v1
with:
node-version: ${{ env.NODE_VERSION }}
node-version: 12

- name: Cache NodeJS modules
uses: actions/cache@v2
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/end-to-end-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ jobs:
# - Cancels all previous workflow runs that have not completed.
# - Set environment variables.
# - Checks out the repository.
# - Reads the desired version of NodeJS from the .nvmrc file.
# - Logs debug information about the runner container.
# - Installs the desired NodeJS version.
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
# - Sets up caching for NPM.
# _ Installs NPM dependencies.
# - Builds WordPress to run from the `build` directory.
Expand Down Expand Up @@ -49,9 +48,6 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v2

- name: Check the desired version of NodeJS
run: echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_ENV

- name: Log debug information
run: |
npm --version
Expand All @@ -66,7 +62,7 @@ jobs:
- name: Install NodeJS
uses: actions/setup-node@v1
with:
node-version: ${{ env.NODE_VERSION }}
node-version: 12

- name: Cache NodeJS modules
uses: actions/cache@v2
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/javascript-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ jobs:
# Performs the following steps:
# - Cancels all previous workflow runs that have not completed.
# - Checks out the repository.
# - Reads the desired version of NodeJS from the .nvmrc file.
# - Logs debug information about the runner container.
# - Installs the desired NodeJS version.
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
# - Sets up caching for NPM.
# - Logs updated debug information.
# _ Installs NPM dependencies.
Expand All @@ -33,9 +32,6 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v2

- name: Check the desired version of NodeJS
run: echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_ENV

- name: Log debug information
run: |
npm --version
Expand All @@ -46,7 +42,7 @@ jobs:
- name: Install NodeJS
uses: actions/setup-node@v1
with:
node-version: ${{ env.NODE_VERSION }}
node-version: 12

- name: Cache NodeJS modules
uses: actions/cache@v2
Expand Down
10 changes: 3 additions & 7 deletions .github/workflows/phpunit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@ jobs:
# - Cancels all previous workflow runs that have not completed.
# - Checks out the repository.
# - Checks out the WordPress Importer plugin (needed for the Core PHPUnit tests).
# - Reads the desired version of NodeJS from the .nvmrc file.
# - Logs debug information about the runner container.
# - Installs the desired NodeJS version.
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
# - Sets up caching for NPM.
# _ Installs NPM dependencies.
# - Builds WordPress to run from the `build` directory.
Expand All @@ -49,9 +48,6 @@ jobs:
- name: Checkout the WordPress Importer plugin
run: svn checkout -r 2387243 https://plugins.svn.wordpress.org/wordpress-importer/trunk/ tests/phpunit/data/plugins/wordpress-importer

- name: Check the desired version of NodeJS
run: echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_ENV

- name: Log debug information
run: |
npm --version
Expand All @@ -66,7 +62,7 @@ jobs:
- name: Install NodeJS
uses: actions/setup-node@v1
with:
node-version: ${{ env.NODE_VERSION }}
node-version: 12

- name: Cache NodeJS modules
uses: actions/cache@v2
Expand Down Expand Up @@ -159,7 +155,7 @@ jobs:
- name: Install NodeJS
uses: actions/setup-node@v1
with:
node-version: ${{ env.NODE_VERSION }}
node-version: 12

- name: Use cached Node modules
uses: actions/cache@v2
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/verify-npm-on-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ jobs:
# Performs the following steps:
# - Cancels all previous workflow runs that have not completed.
# - Checks out the repository.
# - Reads the desired version of NodeJS from the .nvmrc file.
# - Logs debug information about the runner container.
# - Installs the desired NodeJS version.
# - Installs NodeJS 12 (todo: install the version of NPM specified in the `.nvmrc` file to support older branches)
# - Sets up caching for NPM.
# _ Installs NPM dependencies.
# - Builds WordPress to run from the `build` directory.
Expand All @@ -31,9 +30,6 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v2

- name: Check the desired version of NodeJS
run: echo "::set-output NODE_VERSION=$(cat .nvmrc)"

- name: Log debug information
run: |
npm --version
Expand All @@ -45,7 +41,7 @@ jobs:
- name: Install NodeJS
uses: actions/setup-node@v1
with:
node-version: ${{ env.NODE_VERSION }}
node-version: 12

- name: Get NPM cache directory
id: npm-cache
Expand Down