Skip to content

HTML API: Introduce safe HTML templating. #5949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmsnell wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

HTML API: Introduce safe HTML templating. #5949

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
305a91d
HTML API: Introduce HTML Template Renderer
dmsnell Jan 11, 2024
24a2d64
Test refactor of wp_video_shortcut
dmsnell Jan 15, 2024
f841f04
Explore refactors in post-template
dmsnell Jan 15, 2024
6d712f1
Explore refactor of wp-editor code, adds set_modifiable_text()
dmsnell Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Explore refactors in post-template
  • Loading branch information
@dmsnell
dmsnell committed Jan 30, 2024
commit f841f04c55ec535d98e1b75f099aa1d69998fa41
38 changes: 24 additions & 14 deletions src/wp-includes/post-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,19 +296,21 @@ function get_the_content( $more_link_text = null, $strip_teaser = false, $post =
}

if ( null === $more_link_text ) {
$more_link_text = sprintf(
'<span aria-label="%1$s">%2$s</span>',
sprintf(
/* translators: %s: Post title. */
__( 'Continue reading %s' ),
the_title_attribute(
array(
'echo' => false,
'post' => $_post,
$more_link_text = WP_HTML::render(
'<span aria-label="</%label>"></%title></span>',
array(
'label' => sprintf(
/* translators: %s: Post title. */
__( 'Continue reading %s' ),
the_title_attribute(
array(
'echo' => false,
'post' => $_post,
)
)
)
),
__( '(more&hellip;)' )
),
'title' => __( '(more&hellip;)' ),
)
);
}

Expand Down Expand Up @@ -359,9 +361,17 @@ function get_the_content( $more_link_text = null, $strip_teaser = false, $post =

if ( count( $content ) > 1 ) {
if ( $elements['more'] ) {
$output .= '<span id="more-' . $_post->ID . '"></span>' . $content[1];
$output .= WP_HTML::render( '<span id="more-</%id>"></span>', array( 'id' => $_post->ID ) );
$output .= $content[1];
} else {
if ( ! empty( $more_link_text ) ) {
$link_html = WP_HTML::render(
'<a href="</%post_link>" class="more-link"></%link_text></a>',
array(
'post_link' => get_permalink( $_post ) . "#more-{$_post->ID}",
'link_text' => $more_link_text,
)
);

/**
* Filters the Read More link text.
Expand All @@ -371,7 +381,7 @@ function get_the_content( $more_link_text = null, $strip_teaser = false, $post =
* @param string $more_link_element Read More link element.
* @param string $more_link_text Read More text.
*/
$output .= apply_filters( 'the_content_more_link', ' <a href="' . get_permalink( $_post ) . "#more-{$_post->ID}\" class=\"more-link\">$more_link_text</a>", $more_link_text );
$output .= apply_filters( 'the_content_more_link', $link_html, $more_link_text );
}
$output = force_balance_tags( $output );
}
Expand Down