Skip to content

Backport aspect ratio block support #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewserong wants to merge 5 commits into from
Closed

Backport aspect ratio block support #5963

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2cd4a8
Backport aspect-ratio block support
andrewserong Jan 29, 2024
acae78e
Fix test
andrewserong Jan 29, 2024
b4700a7
Add further tests
andrewserong Jan 29, 2024
a5d7e3d
Update theme json tests
andrewserong Jan 29, 2024
4dc1c27
Add a since line for compute_style_properties
andrewserong Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@andrewserong
andrewserong committed Jan 31, 2024
commit acae78e9102ff449feb2bcfe5c3b5ed318d5e673
3 changes: 2 additions & 1 deletion tests/phpunit/tests/style-engine/styleEngine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ public function data_wp_style_engine_get_styles() {
),
'options' => null,
'expected_output' => array(
'css' => 'aspect-ratio:4/3;min-height:50vh;',
'classnames' => 'has-aspect-ratio',
'css' => 'aspect-ratio:4/3;min-height:unset;',
'declarations' => array(
'aspect-ratio' => '4/3',
'min-height' => 'unset',
Expand Down