Skip to content

HTML API: Fix void tag nesting with next_token #5975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 6 commits into from
Closed

HTML API: Fix void tag nesting with next_token #5975

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0deab0a
Use $p variable for processor like other tests
sirreal Jan 30, 2024
e0668b6
Add failing test
sirreal Jan 30, 2024
7890b53
Update ticket
sirreal Jan 30, 2024
31d71de
Ensure void and self-closing elements pop from stack when advancing.
dmsnell Jan 30, 2024
19bea7f
Revert "Use $p variable for processor like other tests"
sirreal Jan 31, 2024
200479b
Merge branch 'trunk' into html-api/fix-void-nesting-next-token
dmsnell Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use $p variable for processor like other tests
  • Loading branch information
@sirreal
sirreal committed Jan 30, 2024
commit 0deab0a60878082c4cf87da10669bdc929e0c891
6 changes: 3 additions & 3 deletions tests/phpunit/tests/html-api/wpHtmlProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,9 @@ public function data_void_tags() {
* @param string $tag_name Name of the tag to test.
*/
public function test_step_in_body_fails_on_unsupported_tags( $tag_name ) {
$fragment = WP_HTML_Processor::create_fragment( '<' . $tag_name . '></' . $tag_name . '>' );
$this->assertFalse( $fragment->next_tag(), 'Should fail to find tag: ' . $tag_name . '.' );
$this->assertEquals( $fragment->get_last_error(), WP_HTML_Processor::ERROR_UNSUPPORTED, 'Should have unsupported last error.' );
$p = WP_HTML_Processor::create_fragment( '<' . $tag_name . '></' . $tag_name . '>' );
$this->assertFalse( $p->next_tag(), 'Should fail to find tag: ' . $tag_name . '.' );
$this->assertEquals( $p->get_last_error(), WP_HTML_Processor::ERROR_UNSUPPORTED, 'Should have unsupported last error.' );
}

/**
Expand Down