Skip to content

Improve inline documentation and avoid escaping values passed to $processor->set_attribute() #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michalczaplinski wants to merge 7 commits into from
Closed

Improve inline documentation and avoid escaping values passed to $processor->set_attribute() #6029

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
95997e6
Do not escape the attribute passed to `$processor->set_attribute()`
michalczaplinski Feb 5, 2024
75d4cf3
Ad block bindings registration PHP docstrings with example usage
michalczaplinski Feb 5, 2024
ec7325b
Update the docstring with more exhaustive info
michalczaplinski Feb 6, 2024
09d325f
Update src/wp-includes/block-bindings.php
gziolo Feb 7, 2024
71b9917
Add inner content to the example docstring
michalczaplinski Feb 7, 2024
014af35
Update custom source value logic in block-bindings.php
michalczaplinski Feb 7, 2024
94385a5
Add a note to `WP_Block_Bindings_Registry::register()` pointing to `r…
michalczaplinski Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/wp-includes/block-bindings.php 
Co-authored-by: Damián Suárez <[email protected]>
  • Loading branch information
@gziolo @retrofox
gziolo and retrofox authored Feb 7, 2024
commit 09d325f28f133daf104391dfe46e8f7e03e752a5
4 changes: 2 additions & 2 deletions src/wp-includes/block-bindings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
/**
* Registers a new block bindings source.
*
* Registering a source consists of defining a **name** for that source as well as a callback function
* which specifies how to get a value from that source and pass it to a block attribute.
* Registering a source consists of defining a **name** for that source and a callback function specifying
* how to get a value from that source and pass it to a block attribute.
*
* Once a source is registered, any block that supports the Block Bindings API can use a value
* from that source by setting its `metadata.bindings` attribute to a value that refers to the source.
Expand Down