Skip to content

Make footnotes support opt-in. #6043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterwilsoncc wants to merge 4 commits into from
Closed

Make footnotes support opt-in. #6043

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23d7772
Opt-in footnote support.
peterwilsoncc Feb 6, 2024
50f6236
Register fn support for posts and pages.
peterwilsoncc Feb 6, 2024
a1f1611
Register footnotes related meta data.
peterwilsoncc Feb 6, 2024
c86c1a1
Remove metadata registration in block [tests fail now].
peterwilsoncc Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove metadata registration in block [tests fail now].
  • Loading branch information
@peterwilsoncc
peterwilsoncc committed Feb 6, 2024
commit c86c1a1fcfece98b84d000c17e97a13cd91abe5d
21 changes: 0 additions & 21 deletions src/wp-includes/blocks/footnotes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,27 +68,6 @@ function render_block_core_footnotes( $attributes, $content, $block ) {
* @since 6.3.0
*/
function register_block_core_footnotes() {
$post_types = get_post_types(
array(
'show_in_rest' => true,
'public' => true,
)
);
foreach ( $post_types as $post_type ) {
// Only register the meta field if the post type supports the editor, custom fields, and revisions.
if ( post_type_supports( $post_type, 'editor' ) && post_type_supports( $post_type, 'custom-fields' ) && post_type_supports( $post_type, 'revisions' ) ) {
register_post_meta(
$post_type,
'footnotes',
array(
'show_in_rest' => true,
'single' => true,
'type' => 'string',
'revisions_enabled' => true,
)
);
}
}
Copy link
Contributor Author

@peterwilsoncc peterwilsoncc Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause the tests to fail but is required for testing wp_register_footnotes_meta_field works as expected.

register_block_type_from_metadata(
__DIR__ . '/footnotes',
array(
Expand Down