Skip to content

REST API: Fix embedded items 'context' regression #6133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mamaduka wants to merge 2 commits into from
Closed

REST API: Fix embedded items 'context' regression #6133

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a707e7
Update unit tests to match the actual request
Mamaduka Feb 17, 2024
a11858d
REST API: Fix embedded items 'context' regression
Mamaduka Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update unit tests to match the actual request
  • Loading branch information
@Mamaduka
Mamaduka committed Feb 17, 2024
commit 2a707e7885e51de1fc292dbf9d38d13234d6196f
26 changes: 8 additions & 18 deletions tests/phpunit/tests/rest-api/rest-navigation-fallback-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,30 +160,20 @@ public function test_embedded_navigation_post_contains_required_fields() {
// First we'll use the navigation fallback to get a link to the navigation endpoint.
$request = new WP_REST_Request( 'GET', '/wp-block-editor/v1/navigation-fallback' );
$response = rest_get_server()->dispatch( $request );
$links = $response->get_links();

// Extract the navigation endpoint URL from the response.
$embedded_navigation_href = $links['self'][0]['href'];
preg_match( '/\?rest_route=(.*)/', $embedded_navigation_href, $matches );
$navigation_endpoint = $matches[1];

// Fetch the "linked" navigation post from the endpoint, with the context parameter set to 'embed' to simulate fetching embedded links.
$request = new WP_REST_Request( 'GET', $navigation_endpoint );
$request->set_param( 'context', 'embed' );
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();
$data = rest_get_server()->response_to_data( $response, true );
$embedded = $data['_embedded']['self'][0];

// Verify that the additional status field is present.
$this->assertArrayHasKey( 'status', $data, 'Response title should contain a "status" field.' );
$this->assertArrayHasKey( 'status', $embedded, 'Response title should contain a "status" field.' );

// Verify that the additional content fields are present.
$this->assertArrayHasKey( 'content', $data, 'Response should contain a "content" field.' );
$this->assertArrayHasKey( 'raw', $data['content'], 'Response content should contain a "raw" field.' );
$this->assertArrayHasKey( 'rendered', $data['content'], 'Response content should contain a "rendered" field.' );
$this->assertArrayHasKey( 'block_version', $data['content'], 'Response should contain a "block_version" field.' );
$this->assertArrayHasKey( 'content', $embedded, 'Response should contain a "content" field.' );
$this->assertArrayHasKey( 'raw', $embedded['content'], 'Response content should contain a "raw" field.' );
$this->assertArrayHasKey( 'rendered', $embedded['content'], 'Response content should contain a "rendered" field.' );
$this->assertArrayHasKey( 'block_version', $embedded['content'], 'Response should contain a "block_version" field.' );

// Verify that the additional title.raw field is present.
$this->assertArrayHasKey( 'raw', $data['title'], 'Response title should contain a "raw" key.' );
$this->assertArrayHasKey( 'raw', $embedded['title'], 'Response title should contain a "raw" key.' );
}

private function get_navigations_in_database() {
Expand Down