Skip to content

Editor: Sync Gutenberg Packages for WordPress 6.5 RC 1 #6218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
youknowriad wants to merge 2 commits into from
Closed

Editor: Sync Gutenberg Packages for WordPress 6.5 RC 1 #6218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de652d9
Editor: Sync Gutenberg Packages for WordPress 6.5 RC 1
youknowriad Mar 4, 2024
dde24e1
Update pattern overrides block bindings callback to use block metadat…
talldan Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update pattern overrides block bindings callback to use block metadat… 
…a name
  • Loading branch information
@talldan @youknowriad
talldan authored and youknowriad committed Mar 4, 2024
commit dde24e161c4c4c656daf883a628ca4376a6d593d
6 changes: 3 additions & 3 deletions src/wp-includes/block-bindings/pattern-overrides.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
* @return mixed The value computed for the source.
*/
function _block_bindings_pattern_overrides_get_value( array $source_args, $block_instance, string $attribute_name ) {
if ( empty( $block_instance->attributes['metadata']['id'] ) ) {
if ( empty( $block_instance->attributes['metadata']['name'] ) ) {
return null;
}
$block_id = $block_instance->attributes['metadata']['id'];
return _wp_array_get( $block_instance->context, array( 'pattern/overrides', $block_id, 'values', $attribute_name ), null );
$metadata_name = $block_instance->attributes['metadata']['name'];
return _wp_array_get( $block_instance->context, array( 'pattern/overrides', $metadata_name, $attribute_name ), null );
}

/**
Expand Down