Skip to content

Add Script Module hooks registration on admin_footer #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 2 commits into from
Closed

Add Script Module hooks registration on admin_footer #6452

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c40732
Add Script Module hooks registration on admin_footer
sirreal Apr 26, 2024
c6e8b49
Switch to admin_print_footer_scripts
sirreal May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add Script Module hooks registration on admin_footer
  • Loading branch information
@sirreal
sirreal committed Apr 26, 2024
commit 1c40732aafd8773d19bc9469a12ae33bb1355914
4 changes: 4 additions & 0 deletions src/wp-includes/class-wp-script-modules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,10 @@ public function add_hooks() {
add_action( $position, array( $this, 'print_import_map' ) );
add_action( $position, array( $this, 'print_enqueued_script_modules' ) );
add_action( $position, array( $this, 'print_script_module_preloads' ) );

add_action( 'admin_footer', array( $this, 'print_import_map' ) );
add_action( 'admin_footer', array( $this, 'print_enqueued_script_modules' ) );
add_action( 'admin_footer', array( $this, 'print_script_module_preloads' ) );
Copy link
Member Author

@sirreal sirreal May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like in #6453, we can use admin_print_footer_scripts which is a bit later and probably more appropriate.

}

/**
Expand Down