Skip to content

Block Bindings: Add context needed by block bindings sources during its processing #6456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SantosGuillamot wants to merge 8 commits into from
Closed

Block Bindings: Add context needed by block bindings sources during its processing #6456

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
958fc10
Push available context when bindings exist
SantosGuillamot Sep 20, 2024
b1d77b2
Remove old filter used to extend `uses_context`
SantosGuillamot Sep 20, 2024
05917ec
Modify comment
SantosGuillamot Sep 20, 2024
f434d57
Modify test to adapt to context changes
SantosGuillamot Sep 20, 2024
0e5fb35
Add uses_context to editor settings
SantosGuillamot Sep 20, 2024
d35e678
Don't use filter to add editor settings
SantosGuillamot Sep 20, 2024
f84b778
Test blocks can only access the right context
SantosGuillamot Sep 20, 2024
757e9b6
Add ticket number to test
SantosGuillamot Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add ticket number to test
  • Loading branch information
@SantosGuillamot
SantosGuillamot committed Sep 20, 2024
commit 757e9b6d86a1f60665c74b682eb6dd577befa7e8
2 changes: 1 addition & 1 deletion tests/phpunit/tests/block-bindings/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public function test_passing_uses_context_to_source() {
/**
* Tests that blocks can only access the context from the specific source.
*
* @ticket 99999
* @ticket 61642
*
* @covers ::register_block_bindings_source
*/
Expand Down