Skip to content

Options: Add 'label' argument to register_setting #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mamaduka wants to merge 6 commits into from
Closed

Options: Add 'label' argument to register_setting #6495

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3ef5d44
Options: Add 'label' argument to register_setting
Mamaduka May 3, 2024
8f05906
Add labels for the settings used by the block editor
Mamaduka May 3, 2024
04d1a06
Add unit test
Mamaduka May 3, 2024
06366dc
Match schema specs
Mamaduka May 3, 2024
22c9237
Update WP API fixtures
Mamaduka May 3, 2024
8f30043
Update WP API fixtures once more
Mamaduka May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit test
  • Loading branch information
@Mamaduka
Mamaduka committed May 3, 2024
commit 04d1a06596e5cf1962e86c81f133b54cc2e1054e
15 changes: 15 additions & 0 deletions tests/phpunit/tests/rest-api/rest-settings-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,4 +781,19 @@ public function test_register_setting_with_custom_additional_properties_value()
$this->assertSame( 2, $response->data['mycustomsetting']['test2'] );
$this->assertSame( 3, $response->data['mycustomsetting']['test3'] );
}

/**
* @ticket 61023
*/
public function test_provides_setting_metadata_in_schema() {
$request = new WP_REST_Request( 'OPTIONS', '/wp/v2/settings' );
$response = rest_get_server()->dispatch( $request );
$data = $response->get_data();
$title = $data['schema']['properties']['title'];

$this->assertSame( 'string', $title['type'] );
$this->assertSame( 'Title', $title['label'] );
$this->assertSame( 'Site title.', $title['description'] );
$this->assertSame( null, $title['default'] );
}
}