-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Block Hooks API: Harmonize ignoredHookedBlocks metadata injection logic #6550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
tjcafferkey
wants to merge
11
commits into
WordPress:trunk
from
tjcafferkey:update/inject-ignored-hooked-blocks-metadata-attributes
Closed
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e93c6a0
Update inject_ignored_hooked_blocks_metadata_attributes to handle wp_…
tjcafferkey 9cd6fdc
Update since annotation for inject_ignored_hooked_blocks_metadata_att…
tjcafferkey 6eaeba4
Update _build_block_template_object_from_prepared_database_object params
tjcafferkey cc50698
Coding standards
tjcafferkey b0c920f
Rename function from _build_block_template_object_from_prepared_datab…
tjcafferkey 691efe7
Unit tests for wp_template objects
tjcafferkey d3aa4ad
template part unit tests
tjcafferkey a1765bc
isset check on post_type
tjcafferkey c8505e0
Remove else statement
tjcafferkey be242ab
Update function comment
tjcafferkey fa8cfb4
Add default-filters update
tjcafferkey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Add default-filters update
- Loading branch information
commit fa8cfb447bb5c3143524f5931d4da41a157bf6d9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove it when the
block_core_navigation_update_ignore_hooked_blocks_metafilter is no longer attached to therest_pre_insert_wp_navigationhook. Since this is done by GB code, we'll have to wait until it's removed there, and blocks code is sync'd to Core.OTOH, we'll have to retain the code in GB for at least two WP releases, as it's required to support the current WordPress version and the one before. So if this PR makes it into WP 6.6, GB still needs to support 6.5, so we'll have to retain the code there.
I'd suggest doing it the other way round: Add the filter unconditionally here, and instead add (yet another 😬)
has_filtercheck in GB. (We will need to wait for GB to release a version that includes that check before we can land the Core PR in order to prevent Coretrunk+ GB stable from breaking.)