Skip to content

Update: register block style variations defined by the theme using the init action #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oandregal wants to merge 12 commits into from
Closed

Update: register block style variations defined by the theme using the init action #6756

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cdba16a
Register block style variations defined by the theme on init
oandregal Jun 7, 2024
ff580e0
Remove registration from wp_theme_json_data_* filters
oandregal Jun 7, 2024
f574d7d
Add comment
oandregal Jun 10, 2024
522b51d
Rename for clarity
oandregal Jun 10, 2024
bfcf9f2
Update wp_register_block_style_variations_from_theme
oandregal Jun 11, 2024
f29b5cc
Remove docblock
oandregal Jun 11, 2024
86f5227
Update wp_register_block_style_variations_from_theme_json_data
oandregal Jun 11, 2024
8c53d8d
Update test_add_registered_block_styles_to_theme_data to register var…
oandregal Jun 11, 2024
d51c763
Register teh newly created style variations.
oandregal Jun 11, 2024
10a638a
Address feedback
oandregal Jun 12, 2024
a40bb88
Test newly created variations are returned by the endpoint
oandregal Jun 12, 2024
f6309c0
Lint: accomodate to core standards
oandregal Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Lint: accomodate to core standards
  • Loading branch information
@oandregal
oandregal committed Jun 12, 2024
commit f6309c0e7e19b47e3d8990b1943f83f54c5b8198
8 changes: 5 additions & 3 deletions tests/phpunit/tests/block-supports/block-style-variations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,11 @@ public function filter_set_theme_root() {
public function test_add_registered_block_styles_to_theme_data() {
switch_theme( 'block-theme' );

// Trigger block style registration that occurs on `init` action.
// do_action( 'init' ) could be used here however this direct call
// means only the updates being tested are performed.
/*
* Trigger block style registration that occurs on `init` action.
* do_action( 'init' ) could be used here however this direct call
* means only the updates being tested are performed.
*/
wp_register_block_style_variations_from_theme();

$variation_styles_data = array(
Expand Down