Skip to content

Background images: resolve ref and ensure appropriate default values #7137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 7 commits into from
Closed

Background images: resolve ref and ensure appropriate default values #7137

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5e6c31c
Block background images have long had "default" values to optimize th…
ramonjd Aug 5, 2024
ae59e5d
Pulling over ref resolution changes.
ramonjd Aug 12, 2024
a360239
Flips the default position from "center" to "50% 50%" - the same effe…
ramonjd Aug 13, 2024
2721bd7
Ensures that background image theme.json objects are replaced, and no…
ramonjd Aug 14, 2024
2a8916e
This code block was removed in https://github.com/WordPress/gutenberg…
ramonjd Aug 15, 2024
968e4ef
Forgot to remove tests condition related to unset
ramonjd Aug 16, 2024
03bf346
After comparing with Gutenberg trunk, this test condition needed to b…
ramonjd Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Forgot to remove tests condition related to unset
  • Loading branch information
@ramonjd
ramonjd committed Aug 26, 2024
commit 968e4efe6954736dc293ee795ca83b3ee5426c0f
5 changes: 0 additions & 5 deletions tests/phpunit/tests/theme/wpThemeJson.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5271,12 +5271,7 @@ public function test_get_resolved_background_image_styles() {
'core/group' => array(
'background' => array(
'backgroundImage' => array(
/*
* Merged theme.json and global styles retain the "ref" value,
* even though the URL is provided in the global styles.
*/
'id' => 123,
'ref' => 'styles.background.backgroundImage',
'url' => 'http://example.org/group.png',
),
),
Expand Down