Skip to content

Conversation

@Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Aug 12, 2024

Gutenberg PR: WordPress/gutenberg#64401 and WordPress/gutenberg#64459.
Trac ticket: https://core.trac.wordpress.org/ticket/61884


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@Mamaduka Mamaduka self-assigned this Aug 12, 2024
@github-actions
Copy link

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mamaduka.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Mamaduka Mamaduka force-pushed the fix/site-editor-preload-paths branch from e10037b to 61b2a69 Compare August 16, 2024 03:12
@Mamaduka Mamaduka changed the title Editor: Fix Template Parts post type preload path Editor: Fix preloaded REST API paths Aug 16, 2024
@Mamaduka Mamaduka requested a review from noisysocks August 16, 2024 03:31
Copy link
Member

@getsource getsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you @Mamaduka !

@Mamaduka
Copy link
Member Author

@Mamaduka Mamaduka closed this Aug 16, 2024
@Mamaduka Mamaduka deleted the fix/site-editor-preload-paths branch August 16, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants