Skip to content

Proposal: Add label argument to register_meta function #7298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SantosGuillamot wants to merge 8 commits into from
Closed

Proposal: Add label argument to register_meta function #7298

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
696b3f1
Add `label` arg to `register_meta`
SantosGuillamot Sep 5, 2024
7593c51
Add label to REST API schema
SantosGuillamot Sep 5, 2024
edc444c
Adapt unit tests
SantosGuillamot Sep 5, 2024
c307b4f
Use 'title' instead of 'label' in schema
SantosGuillamot Sep 6, 2024
74e3465
Add unit test to check title in schema
SantosGuillamot Sep 6, 2024
0abab55
Add since tag
SantosGuillamot Sep 6, 2024
c0281e3
Add ticket number to unit test
SantosGuillamot Sep 6, 2024
fcb7b63
Adapt unit test assertions
SantosGuillamot Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Adapt unit test assertions
  • Loading branch information
@SantosGuillamot
SantosGuillamot committed Sep 16, 2024
commit fcb7b6321dcc4e5c9748df005ad4469c976df8c4
8 changes: 4 additions & 4 deletions tests/phpunit/tests/rest-api/rest-post-meta-fields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3103,8 +3103,8 @@ public function test_default_is_added_to_schema() {
$response = rest_do_request( $request );

$schema = $response->get_data()['schema']['properties']['meta']['properties']['with_default'];
$this->assertArrayHasKey( 'default', $schema );
$this->assertSame( 'Goodnight Moon', $schema['default'] );
$this->assertArrayHasKey( 'default', $schema, 'Schema is expected to have the default property' );
$this->assertSame( 'Goodnight Moon', $schema['default'], 'Schema default is expected to be defined and contain the value of the meta default argument.' );
}

/**
Expand All @@ -3116,8 +3116,8 @@ public function test_title_is_added_to_schema() {

$schema = $response->get_data()['schema']['properties']['meta']['properties']['with_label'];

$this->assertArrayHasKey( 'default', $schema );
$this->assertSame( 'Meta Label', $schema['title'] );
$this->assertArrayHasKey( 'title', $schema, 'Schema is expected to have the title property' );
$this->assertSame( 'Meta Label', $schema['title'], 'Schema title is expected to be defined and contain the value of the meta label argument.' );
}

/**
Expand Down