-
Notifications
You must be signed in to change notification settings - Fork 3.2k
51423: wp_privacy_generate_personal_data_export_file fixes type match for array_merge (PHP 8) #758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hellofromtonya
wants to merge
20
commits into
WordPress:master
from
hellofromtonya:fix/php8.0/51423-wp-admin/includes/privacy-tools.php
Closed
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
56df70d
wp-admin/includes/privacy-tools.php: Fix a PHP 8.0 fatal "Parameter #…
xknown c44e87a
Sends json error when '_export_data_grouped' exists but not array.
hellofromtonya 2ac2209
Removes extra fix to keep this PR focused on one function.
hellofromtonya f8edbcc
Merge branch 'master' into fix/php8.0/51423-wp-admin/includes/privacy…
hellofromtonya a1185ff
Adds tests for array_merge warning json error.
hellofromtonya 79ac839
Abstracts setup for export contents to make it easier to add tests.
hellofromtonya 901ff24
Adds tests to validate groups json behavior.
hellofromtonya 00e73a0
Adds tests for json export to validate export data grouped.
hellofromtonya 8ab0d23
Merge branch 'master' into fix/php8.0/51423-wp-admin/includes/privacy…
hellofromtonya 324af66
Adds _doing_it_wrong when meta value exists but is not an array.
2f242e1
Updates the tests.
5baeff0
Fixes test naming.
ef28395
Fixes closing ) placement for __().
11551b8
Cast to array when not an array.
ae22009
Skip array_merge when not an array.
3a9db91
Make json contents test more robust.
47f7ba0
Remove extra fix (new PR).
2483915
Sets vars to match current values to ensure same report output results.
44d9507
Fixes tests.
11361ca
Adds more test data for invalid type.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Sends json error when '_export_data_grouped' exists but not array.
This change retains PHP Warning message (though via JSON) to alert developer where the problem exists. Why? To ensure it does not silently pass through this code, which would make debugging harder.
- Loading branch information
commit c44e87a16355b496eff2ad1ecff9e61b0d55532c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.