Skip to content

Conversation

@sirreal
Copy link
Member

@sirreal sirreal commented Oct 21, 2024

WordPress/gutenberg#66183
#7600

Trac ticket: https://core.trac.wordpress.org/ticket/62465


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@gziolo
Copy link
Member

gziolo commented Oct 22, 2024

Tested in WordPress Playground, everything works correctly with the Query block and region-based client-side navigation.

@sirreal
Copy link
Member Author

sirreal commented Nov 14, 2024

@michalczaplinski @DAreRodz @luisherranz This was necessary to workaround a bug that was fixed in WordPress/gutenberg#66183. Do you want to take this over to remove the redundant state now that the bugfix is in Core?

@michalczaplinski michalczaplinski marked this pull request as ready for review November 18, 2024 18:09
@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, czapla, gziolo.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@michalczaplinski michalczaplinski self-requested a review November 18, 2024 18:09
Copy link
Contributor

@michalczaplinski michalczaplinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and the Query Loop works just fine. The router animation continues to appear now.

@michalczaplinski
Copy link
Contributor

Commited to Core in https://core.trac.wordpress.org/changeset/59416

@sirreal sirreal deleted the remove/interactivity-router-redundant-server-state branch August 5, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants