Skip to content

51423: wp_privacy_process_personal_data_export_page() fixes type match for array_merge (PHP 8) #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hellofromtonya wants to merge 2 commits into
base: master
Choose a base branch
from
Open

51423: wp_privacy_process_personal_data_export_page() fixes type match for array_merge (PHP 8) #776

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7f11b3
Adds is_array check. Props @xknown.
hellofromtonya Nov 28, 2020
7c168d2
Sends json error when '_export_data_raw' not array.
hellofromtonya Nov 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adds is_array check. Props @xknown.
  • Loading branch information
@hellofromtonya
hellofromtonya committed Nov 28, 2020
commit b7f11b320b7c33ce881b58df0a55c1521d11bc00
2 changes: 1 addition & 1 deletion src/wp-admin/includes/privacy-tools.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,7 +769,7 @@ function wp_privacy_process_personal_data_export_page( $response, $exporter_inde
} else {
$accumulated_data = get_post_meta( $request_id, '_export_data_raw', true );

if ( $accumulated_data ) {
if ( $accumulated_data && is_array( $accumulated_data ) ) {
$export_data = $accumulated_data;
}
}
Expand Down