Skip to content

Add logic to sort posts by hierarchy #8014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oandregal wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

Add logic to sort posts by hierarchy #8014

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1545b5
Add logic to sort posts by hierarchy
oandregal Dec 17, 2024
09fb57b
Declare orderby_hierarchy in post controller test
oandregal Dec 17, 2024
48b3a53
Update wp-api-generated fixture
oandregal Dec 18, 2024
cd2f956
Do not use filters
oandregal Dec 26, 2024
a6000fc
Use class directly and remove static cache
oandregal Dec 26, 2024
b4a54ef
Fix PHP lint issues
oandregal Dec 26, 2024
ec420bb
Update unit tests to latest changes
oandregal Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PHP lint issues
  • Loading branch information
@oandregal
oandregal committed Dec 26, 2024
commit b4a54ef382b6bcfbcd92e77cdb503e4d98cbd113
10 changes: 5 additions & 5 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,10 +411,10 @@ static function ( $format ) {

if ( Hierarchical_Sort::is_eligible( $request ) ) {
$result = Hierarchical_Sort::run( $args );
$this->levels = $result[ 'levels' ];
$this->levels = $result['levels'];
Copy link

@mcsf mcsf Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oandregal: Correct me if I'm wrong, but this is the same problem that we had with static variables in the original Gutenberg PR. The concept of posts controller doesn't map 1:1 to the concept of a query, and so attaching the state of a query (levels) to a controller instance that can outlive it ($this) seems dangerous.


$args[ 'post__in' ] = $result[ 'post_ids' ];
$args[ 'orderby' ] = 'post__in';
$args['post__in'] = $result['post_ids'];
$args['orderby'] = 'post__in';
}

/**
Expand Down Expand Up @@ -3010,15 +3010,15 @@ public function get_collection_params() {
$post_type = get_post_type_object( $this->post_type );

if ( $post_type->hierarchical || 'attachment' === $this->post_type ) {
$query_params['parent'] = array(
$query_params['parent'] = array(
'description' => __( 'Limit result set to items with particular parent IDs.' ),
'type' => 'array',
'items' => array(
'type' => 'integer',
),
'default' => array(),
);
$query_params['parent_exclude'] = array(
$query_params['parent_exclude'] = array(
'description' => __( 'Limit result set to all items except those of a particular parent ID.' ),
'type' => 'array',
'items' => array(
Expand Down
Loading