Skip to content

Ensure block editor preloading middleware JSON is correctly escaped #8145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 14 commits into from
Closed

Ensure block editor preloading middleware JSON is correctly escaped #8145

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0230b1d
Add test with assertEqualHTML
sirreal Jun 11, 2025
97d3098
Update or fix tests
sirreal May 30, 2025
7e5d18a
Clean up test function name and documentation
sirreal Jun 11, 2025
af03c20
Revert test/data provider rename
sirreal Jun 11, 2025
38dfe96
Simplify test
sirreal Jun 11, 2025
5bf2ebf
Fix issue with other site urls in tests
sirreal Jun 11, 2025
5f10fb6
Fix json encode that may break enclosing script tag
sirreal Jan 17, 2025
e5b04e4
Always use JSON_HEX_TAG | JSON_UNESCAPED_SLASHES flags
sirreal Jun 11, 2025
554080b
Revert "Always use JSON_HEX_TAG | JSON_UNESCAPED_SLASHES flags"
sirreal Jul 16, 2025
3f4f86d
Revert "Fix json encode that may break enclosing script tag"
sirreal Jul 16, 2025
495e938
Reapply "Fix json encode that may break enclosing script tag"
sirreal Jul 16, 2025
f060cd4
Reapply "Always use JSON_HEX_TAG | JSON_UNESCAPED_SLASHES flags"
sirreal Jul 16, 2025
3927310
Fix typo and improve test description
sirreal Aug 19, 2025
1b41f43
Fix test
sirreal Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify test
  • Loading branch information
@sirreal
sirreal committed Aug 19, 2025
commit 38dfe96e0cf1800c295133eee0ee717fe43d7551
8 changes: 3 additions & 5 deletions tests/phpunit/tests/blocks/editor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,11 +744,9 @@ public function test_ensure_preload_data_script_tag_closes() {
)
);

// Need set up rest requests with some data like `<!-- <script>`...
wp_scripts()->registered['wp-api-fetch']->extra['after'] = array();
// Prevent a bunch of noisy or unstable data from being included in the test output.
wp_scripts()->registered['wp-api-fetch']->ver = 'test';
$src = includes_url( '/test-src/api-fetch.js' );
wp_scripts()->registered['wp-api-fetch']->src = $src;
wp_scripts()->registered['wp-api-fetch']->extra['after'] = array();

block_editor_rest_api_preload(
array( '/test/v0/test-62797' ),
Expand All @@ -759,7 +757,7 @@ public function test_ensure_preload_data_script_tag_closes() {
wp_scripts()->do_item( 'wp-api-fetch' );
$output = ob_get_clean();
$expected = <<<HTML
<script src="{$src}?ver=test" id="wp-api-fetch-js"></script>
<script src="http://example.org/wp-includes/js/dist/api-fetch.min.js?ver=test" id="wp-api-fetch-js"></script>
<script id="wp-api-fetch-js-after">
wp.apiFetch.use( wp.apiFetch.createPreloadingMiddleware( {"/test/v0/test-62797":{"body":["\\u003C!-- unclosed comment and a script tag \\u003Cscript\\u003E\\u003C/script\\u003E"],"headers":{"Allow":"GET"}}} ) );
</script>
Expand Down