Blocks: Align with Gutenberg the name of generated asset handle for core blocks #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…ore blocks Related PR: WordPress/gutenberg#25220.
aristath
requested changes
Dec 16, 2020
Member
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
The code makes sense. Tested it and it works as expected 👍
Nitpicking: Yoda conditions as per the Coding Standfards
Co-authored-by: Ari Stathopoulos <[email protected]>
Co-authored-by: Ari Stathopoulos <[email protected]>
aristath
approved these changes
Dec 16, 2020
Member
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
Thank you for the changes! LGTM 👍
aristath
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/50328
Related Gutenberg PR: WordPress/gutenberg#25220.
This change tries to align with the latest changes added by @aristath to the Gutenberg project. As part of styles splitting for core blocks, there was a special pattern introduced for how style handles are named. Ideally, we would apply it to all blocks but there might be some backward compatibility considerations so I left the handling for non-core blocks unchanged.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.