-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Block Bindings: Allow more generic setting of block attributes #9469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ockham
wants to merge
30
commits into
WordPress:trunk
from
ockham:try/simplify-block-bindings-replace-html
Closed
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
7f1f6a0
Introduce data provider to allow extending test coverage
ockham 054756d
Add test coverage for Button block's text attribute
ockham b328dee
Block Bindings: Simplify replace_html() method
ockham 21e80e2
Add WP_Block_Bindings_Processor class
ockham 1c70bc3
Use WP_Block_Bindings_Processor for block bindings
ockham 8f76759
Add kses back :/
ockham b7b7ca5
WPCS
ockham bb7c906
Remove obsolete var
ockham 103a5c4
Indentation
ockham 3f2e32b
Return true upon success
ockham 85b6354
Add basic PHPDoc
ockham b67890e
Add more PHPDoc
ockham 6bc4fd5
Add basic test coverage
ockham d943cd8
Allow setting attributes
ockham 527c5d8
Increase test coverage
ockham 86e836d
Increase test coverage
ockham dad7380
Add more commentary and warnings
ockham 88af5ff
Do not explose block bindings processor class
sirreal a56f978
Remove block bindings processor class
sirreal 7c3fc45
wpcs
sirreal 66fef38
Make the hidden class instance static
sirreal 24a0b0d
Use Reflection to make tests work again
ockham 2e7df73
Block Bindings Processor: Tweak test to break with current implementa…
ockham e2f0a38
Block Bindings Processor: Base implementation on WP_HTML_Text_Replace…
ockham b045050
Remove now-obsolete build() alias method
ockham e739c6c
Rename test file
ockham 6a4a3a3
Correct @since PHPDoc
ockham 4dbb0e5
More descriptive variable names
ockham a18e435
Remove static var
ockham 3410f40
Make sure we're not stopped on atomic/void/self-closing element
ockham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make the hidden class instance static
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.