Block Bindings: Update render tests #9748
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of changes made to the tests in WordPress/gutenberg#71389.
Independently of that PR, I think these changes make sense, since they make the tests less verbose and less redundant.
The changes are basically as follows:
block_bindings_supported_attributes_{$block_name}filter to register atest/block's attribute as supported by Block Bindings, rather than using an actual block (Paragraph) for most tests.get_value_callbackworks correctly (accepts arguments; correctly includes symbols and numbers; return value is sanitized when rendered) into one, by using adataProvider.uses_contextproperty.No semantic changes have been made, at least not deliberately -- the tests should still cover the same expected behavior.
Trac ticket: https://core.trac.wordpress.org/ticket/63840
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.