Remove SOTW banner from homepage #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
added
the
[Component] Content
| <!-- /wp:wporg/language-suggest --> | ||
|
|
||
| <!-- wp:cover {"url":"https://wordpress.org/files/2022/08/Editor.webp","id":11558,"dimRatio":0,"minHeight":670,"minHeightUnit":"px","align":"full","style":{"spacing":{"padding":{"top":"5rem","right":"var:preset|spacing|edge-space","bottom":"5rem","left":"var:preset|spacing|edge-space"}}}} --> | ||
| <!-- wp:cover {"url":"https://wordpress.org/files/2022/08/Editor.webp","id":11558,"dimRatio":0,"minHeight":670,"minHeightUnit":"px","align":"full","anchor":"editor","style":{"spacing":{"padding":{"top":"5rem","right":"var:preset|spacing|edge-space","bottom":"5rem","left":"var:preset|spacing|edge-space"}}}} --> |
Contributor
There was a problem hiding this comment.
I see you mention anchor props in the description, I'm assuming that anchors need to be present in the block attributes now?
StevenDufresne
approved these changes
Feb 22, 2023
Contributor
StevenDufresne
left a comment
StevenDufresne
left a comment
There was a problem hiding this comment.
This is working as expected.
I have double-checked and the anchor changes are necessary. I don't know the source of change for the margins but explicitly adding them should help future proof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #206
Only the banner has been removed but there are quite a few markup changes, probably as a result of Gutenberg changes, eg. H2s need to have
margin-top: 0,anchorprop, etc.Including full screenshots for easy comparison.
Note that the language suggestion banner is missing locally because there is a CORS failure when requesting https://wordpress.org/lang-guess/lang-guess-ajax.php
Screenshots
Desktop
Tablet
Mobile
How to test the changes in this Pull Request: