Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 2, 2020

Please follow this checklist. Please check each appropriate box (put an 'x' or check it after creating the PR).

  • REQUIRED: Do you have an Issue assigned to you within the v1 milestone for this PR? Put the Issue number here: Localization is unstable on app launch... #776
  • Provided detailed pull request description and a succinct title (consider template below for guidance).
  • Tested your changes, especially after any code review iterations.
  • Included any relevant screenshots of UI updates.
  • Followed the Contributor Guidelines.
  • Verified all contributions are properly licensed pursuant to the LICENSE file in the root of the repository.
  • Verified your name is in the content/credits.yaml file (if you want it to be).

After all boxes above are checked, request and receive an Approved review from any team member knowledgable in the area (TODO team member list). Once approved, the team member will assign your review to a Committer or use the needs-merge label.

What does this PR accomplish?

Fixes #776 by setting the locale as soon as the app launches. There is a bug currently in Flutter that will be fixed by flutter/engine#17473, but that will take some time to roll through dev/beta/stable. In the mean time, this fix is safe and will cooperate fine even once the issue is fixed upstream. Once flutter/engine#17473 has rolled into the SDK used by this application, the code added here is safe to remove.

Did you add any dependencies?

No

How did you test the change?

Manually.

Copy link
Contributor

@patniemeyer patniemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Thanks! And thank you for the background info.

@dnfield
Copy link
Contributor Author

dnfield commented Apr 2, 2020

Thanks for the reviews! I do not have commit permission, so someone else will have to commit this.

@advayDev1 advayDev1 merged commit 9e8aa6a into WorldHealthOrganization:master Apr 3, 2020
@advayDev1 advayDev1 added this to the v1.0 milestone May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Localization is unstable on app launch...

3 participants