Skip to content

Conversation

@cshung
Copy link

@cshung cshung commented Jul 9, 2021

Fixes the build error after rebase.
Fixing the test failure by adding the flag.
Make sure we print out errors when they occur
Make sure we print out the string "PROFILER_TEST_PASSES\n" exactly as the harness is looking for it.
Instead of using assert, check for the conditions, so that it will work on release build, and
Fixing a few typos here and there.

Copy link
Owner

@Yauk Yauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Approved.

@Yauk Yauk merged commit 01bfb3b into Yauk:private/20210608_prototype-allocation-profiler Jul 9, 2021
@cshung cshung deleted the changed branch July 9, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants