Skip to content

Fix not identifying all Github token occurrences in a file Issue #858 #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix not identifying all Github token occurrences in a file Issue #858 #859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix not identifying all Github token occurrences in a file Issue #858
  • Loading branch information
@karamuz
karamuz committed Jun 21, 2024
commit de43fe51cf833dfcc8b272904bd2b74b99eebd0c
9 changes: 2 additions & 7 deletions detect_secrets/plugins/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,8 @@ def denylist(self) -> Iterable[Pattern]:

def analyze_string(self, string: str) -> Generator[str, None, None]:
for regex in self.denylist:
for match in regex.findall(string):
if isinstance(match, tuple):
for submatch in filter(bool, match):
# It might make sense to paste break after yielding
yield submatch
else:
yield match
for match in regex.finditer(string):
yield match.group(0) # Returns the entire matched string

@staticmethod
def build_assignment_regex(
Expand Down