Skip to content

Fix check bypass via square brackets Issue #857 #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix check bypass via square brackets Issue #857 #860

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35f94b8
[Fix] Square brackets bypass Issue #857
tsigouris007 Jul 16, 2024
74b7a92
[Test] Add test case for issue #857
tsigouris007 Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Fix] Square brackets bypass Issue #857
  • Loading branch information
@tsigouris007
tsigouris007 committed Jul 2, 2025
commit 35f94b824ec3b60440e3c25b67808edbea3893e3
10 changes: 9 additions & 1 deletion detect_secrets/filters/heuristic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,15 @@ def _get_indirect_reference_regex() -> Pattern:
# [^\v]* -> Something except line breaks
# [\]\)] -> End of indirect reference: ] or )
# )
return re.compile(r'([^\v=!:]*)\s*(:=?|[!=]{1,3})\s*([\w.-]+[\[\(][^\v]*[\]\)])')
return re.compile(
r'([^\v=!:"<%>]*)\s*(:=?|[!=]{1,3}|\|\|)\s*('
r'[\w.-]+[\[\(][^\v]*[\]\)]' # Matches ENV[...] or similar references
r'|'
r'\'[^\']*\'' # Matches single-quoted strings
r'|'
r'"[^"]*"' # Matches double-quoted strings
r')'
)


def is_lock_file(filename: str) -> bool:
Expand Down