Use curly brace format instead of explicit ARRAY keyword when specifying Redshift group members #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpops
reviewed
Jul 31, 2017
| let :params do | ||
| { | ||
| :groupmembers => ['testuser1', 'testuser2'], | ||
| :groupmembers => "{\"testuser1\", \"testuser2\"}", |
Member
There was a problem hiding this comment.
I much preferred the prior API. Is it possible to expose the previous API to the caller (array of names) and then do the escaping / formatting yourself inside postgresql::server::dbgroup?
Author
There was a problem hiding this comment.
Added a set of regexp rules to convert puppet arrays to psql arrays.
…uppet array to be passed as input. This makes the following assumptions: 1. A valid puppet array is passed in as input (input is trusted, not supplied by an external party) 2. Users do not contain special characters (such as commas or double quotes) 3. Array syntax from puppet is consistent with its runbook, in re, no square brackets, items appear in the array without surrounding quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses curly brace notation instead of the
ARRAYkeyword for Redshift group member specification. The default is also now updated to'{}'accordingly.This should simplify the amount of typing required for specifying group members, as well as making error messages in group specification easier to understand.