This repository was archived by the owner on May 13, 2025. It is now read-only.
Fix double type to float and cleanup #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoy
suggested changes
May 9, 2018
smoy
left a comment
smoy
left a comment
There was a problem hiding this comment.
Do you have unit test that test against this change?
| case java.sql.Types.REAL => DoubleType | ||
| case java.sql.Types.REF => StringType | ||
| case java.sql.Types.ROWID => LongType | ||
| case java.sql.Types.REAL => FloatType |
There was a problem hiding this comment.
You probably want an inline comment to remind future reader Redshift Real is represented in 4 bytes IEEE Float. (it's a special snowflake because JDBC Real is usually 8 bytes IEEE float but PostgreSQL (thus Redshift because of lineage) treats Real differently.
smoy
approved these changes
May 9, 2018
|
LGTM, ship it. |
sungjuly
added a commit
to sungjuly/spark-redshift
that referenced
this pull request
Jan 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix double type to float and cleanup non redshift types