Use official Magento2 coding standard as base for YouweMagento2 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 12, 2022 16:44
This is to avoid collision with upstream Magento2 coding standard. This is a breaking change and will require a new major version number when it is released.
added 5 commits
September 14, 2022 10:16
This is feasible as we are releasing the next major version of this pacakge anyway. (See previous commit.)
leonhelmus
requested review from
Anve94,
arnoudhgz,
igorwulff,
leonhelmus and
rutgerrademaker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes breaking changes, and therefore should be released as a new major version.
When this is released and tagged, we can update relying packages, like the testing suite.