Testing #532

ericgaspar · 2022-12-10T18:02:52Z

Update to 25.0.3
Only warn about 32-bit deprecation
Update to recommanded PHP8.1

32 bit support : warn but don't block upgrade/install (v25)

ericgaspar · 2022-12-10T18:04:34Z

!testme

yunohost-bot · 2022-12-10T18:04:37Z

Fingers crossed!

into testing

lapineige · 2022-12-10T18:10:33Z

Please merge #533 first

lapineige · 2022-12-10T18:39:26Z

Upgrade didn't work fine on my side as it triggered an internal server error, and the log still shows the same error :(

lapineige · 2022-12-10T19:12:15Z

That's a quota issue, see: nextcloud/server#34905 (comment)

lapineige · 2022-12-11T15:44:39Z

Fixed by this manual change : nextcloud/server#34905 (comment)

lapineige · 2022-12-14T09:06:04Z

Let's merge ?

ericgaspar · 2022-12-14T09:09:46Z

@lapineige It is not extra clear to me if user with 32 bits arch machines will still have to manually apply this tweaks nextcloud/server#34905 (comment)

lapineige · 2022-12-15T19:37:35Z

Same for me. I asked on their repository.

Lots of people are asking for this upgrade on the forum, that's why I was suggesting to merge… but maybe it's better to make sure they won't have a broken Nextcloud first 😅

lapineige · 2022-12-20T10:09:25Z

PR ongoing on Nextcloud side to fix that bug nextcloud/server#35734 (update: it need testers).
Let's wait for it ?

And maybe #530 ?

Co-authored-by: Éric Gaspar <[email protected]>

ericgaspar · 2023-01-22T14:58:27Z

Well yes, the idea is to keep 32-bit compatibility as much as possible. We also need to inform 32-bit user that support will soon be dropped.
How soon is soon? It doesn't seem clear upstream
@Gredin67 If you have a better warning formulation please change it

into testing

lapineige · 2023-01-22T20:31:54Z

@Gredin67 If you have a better warning formulation please change it

Nextcloud might drop 32bit support in the future. It is recommended that you upgrade to a 64 bits architecture.

This would not add to specific detail about a version number that could fluctuate/be outdated very soon, not urge too much our users to upgrade, and still warn then that they should plan it somewhere in the quite near future.
What do you think ?

lapineige · 2023-01-23T10:07:14Z

nextcloud/server#35734 (comment)
25.0.3 should be fixing the bug, at least most of the time, so I would vote for a merge. That would release the burden of many people not able to upgrade because of the previous (blocking) warning (and also lighten our support work), and for the few that might still encounter the bug there is a manual fix available.
Last CI and then we merge ?

lapineige · 2023-01-23T10:07:27Z

!testme

yunohost-bot · 2023-01-23T10:07:29Z

Alrighty!

lapineige · 2023-01-23T10:09:14Z

Oh and let's merge #530 too ?

Update to php8.1

lapineige · 2023-01-23T14:39:05Z

Upgrade went fine on my side.
But I still have the quota bug :/

Gredin67 · 2023-01-24T09:20:53Z

scripts/upgrade

 then
-    ynh_die --message="Sorry, Nextcloud has deprecated 32-bit support"
+    ynh_print_warn --message="Nextcloud will soon deprecate 32-bit support. It is recommended to upgrade to a 64-bit architecture."
 fi


My suggestion: "Nextcloud will deprecate 32-bit support within the next years. You should start thinking about upgrading to a 64-bit architecture."

lapineige · 2023-01-24T22:03:43Z

!testme

yunohost-bot · 2023-01-24T22:03:45Z

Fingers crossed!

lapineige · 2023-01-24T22:03:57Z

Install failed for some strange reason 🤔

ericgaspar · 2023-01-24T22:08:37Z

This is just the CI failing a successfully installed app

lapineige · 2023-01-25T18:11:08Z

CI is fully happy.

Let's merge ?

tituspijean

Tested and working!

ericgaspar and others added 7 commits December 9, 2022 16:34

Update to PHP8.1

c6f8c79

Auto-update README

932d296

32 bit warning : don't block upgrades

9ba5ca3

32-bit warning : don't block install

e0f7b24

Merge pull request #531 from lapineige/master

7be82b9

32 bit support : warn but don't block upgrade/install (v25)

Update manifest.json

862de41

Auto-update README

78e934b

ericgaspar requested review from JimboJoe, alexAubin, kay0u and tituspijean December 10, 2022 18:03

ericgaspar added 2 commits December 10, 2022 19:09

fic comment

2dd5c1e

Merge branch 'testing' of https://github.com/YunoHost-Apps/nextcloud_ynh

7a08b37

into testing

Fix typo

d0682fe

tituspijean previously approved these changes Dec 10, 2022

View reviewed changes

ericgaspar and others added 5 commits December 20, 2022 11:33

Merge branch 'testing' into Update-to-PHP8.1

c64f5cc

link tutorial on installing onlyoffice_ynh for arm

8928841

Update doc/DISCLAIMER.md

459611c

Co-authored-by: Éric Gaspar <[email protected]>

Update doc/DISCLAIMER_fr.md

df1884e

Co-authored-by: Éric Gaspar <[email protected]>

Update doc/DISCLAIMER.md

b5ec7a6

Co-authored-by: Éric Gaspar <[email protected]>

ericgaspar and others added 2 commits January 22, 2023 15:56

Update install

888808f

Auto-update README

1bc25a7

ericgaspar added 3 commits January 22, 2023 15:58

Update upgrade

c5da6cd

Merge branch 'testing' of https://github.com/YunoHost-Apps/nextcloud_ynh

54469fe

into testing

be vague

a7df242

ericgaspar requested a review from tituspijean January 22, 2023 15:16

ericgaspar added 2 commits January 22, 2023 16:22

Update install

8ea0038

Update _common.sh

2e6790a

ericgaspar added 2 commits January 22, 2023 21:57

Fix warning

9e801dc

Fix warning

8802926

lapineige previously approved these changes Jan 23, 2023

View reviewed changes

ericgaspar added 2 commits January 23, 2023 11:16

Merge branch 'testing' into Update-to-PHP8.1

148726c

Merge pull request #530 from YunoHost-Apps/Update-to-PHP8.1

eb3b4e2

Update to php8.1

ericgaspar dismissed lapineige’s stale review via eb3b4e2 January 23, 2023 10:16

lapineige mentioned this pull request Jan 23, 2023

[stable25] Quota value as float for 32-bit systems nextcloud/server#35734

Merged

4 tasks

Gredin67 reviewed Jan 24, 2023

View reviewed changes

tituspijean approved these changes Jan 25, 2023

View reviewed changes

ericgaspar merged commit a3ef6ef into master Jan 25, 2023

Testing #532

Testing #532

Uh oh!

Conversation

ericgaspar commented Dec 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericgaspar commented Dec 10, 2022

Uh oh!

yunohost-bot commented Dec 10, 2022

Uh oh!

lapineige commented Dec 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lapineige commented Dec 10, 2022

Uh oh!

lapineige commented Dec 10, 2022

Uh oh!

lapineige commented Dec 11, 2022

Uh oh!

lapineige commented Dec 14, 2022

Uh oh!

ericgaspar commented Dec 14, 2022

Uh oh!

lapineige commented Dec 15, 2022

Uh oh!

lapineige commented Dec 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericgaspar commented Jan 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lapineige commented Jan 22, 2023

Uh oh!

lapineige commented Jan 23, 2023

Uh oh!

lapineige commented Jan 23, 2023

Uh oh!

yunohost-bot commented Jan 23, 2023

Uh oh!

lapineige commented Jan 23, 2023

Uh oh!

lapineige commented Jan 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gredin67 Jan 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lapineige commented Jan 24, 2023

Uh oh!

yunohost-bot commented Jan 24, 2023

Uh oh!

lapineige commented Jan 24, 2023

Uh oh!

ericgaspar commented Jan 24, 2023

Uh oh!

lapineige commented Jan 25, 2023

Uh oh!

tituspijean left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ericgaspar commented Dec 10, 2022 •

edited

Loading

lapineige commented Dec 10, 2022 •

edited

Loading

lapineige commented Dec 20, 2022 •

edited

Loading

ericgaspar commented Jan 22, 2023 •

edited

Loading

lapineige commented Jan 23, 2023 •

edited

Loading

Gredin67 Jan 24, 2023 •

edited

Loading