Fix password Element type (1.x) #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claytondaley
changed the title
|
See also zendframework/zendframework#7166 |
Danielss89
added a commit
that referenced
this pull request
Feb 1, 2015
Fix password Element type (1.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ZF2 password elements are built with extra layers of intelligence. For example, an edit form will not (by default) send the password from a database object back to the browser.
ZF2 issue #2602 notes that a Password element is not automatically created when the password attribute is sent. Rather the
type => passwordneeds to be included in the parent array. This causes ZfcUser forms (and inheritors) to miss out on these features.This patch fixes this issue for the 1.x branch. I have no idea what side-effects this may have as some users may depend on the Element's incorrect behaviors, but it strikes me as an appropriate BC risk since it should enhance intrinsic security of anything that uses ZfcUser.