Added support for polymorphic roles and multiple scopes...basically Model ACLs. #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pivot table with additional fields and adding support for specifying a Model class and Model object id when calling addRole. All other relevant calls have been updated to support optional $modelName and $modelId fields such that you can now apply a role or permission to any model object. Added new HasModelRole trait to the package to allow for easy role and permission checking of the current user on any Model. Added unit tests to validate the behavior of the new features.
|
@deardooley Can you perhaps solve these test errors thrown by Travis CI? |
…llow null model_id and model_type fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for polymorphic roles and multiple scopes by extending the pivot table with additional fields and adding support for specifying a Model class and Model object id when calling addRole. All other relevant calls have been updated to support optional $modelName and $modelId fields such that you can now apply a role or permission to any model object.
Added new HasModelRole trait to the package to allow for easy role and permission checking of the current user on any Model.
Added unit tests to validate the behavior of the new features.