Refactoring Entrust.php

[imanghafoori1]

Entrust.php is somewhat refactored.
Resulting in a more concise and cleaner code by removing some duplication.
and your unit tests still pass...

I hope you like it...
I can continue to work on it and apply some design patterns if you agree upon this commit.

[jobrios]

The duplication removal and greater expressiveness you've got here are good ideas, but you should avoid creating additional state variables like $this->filterName.

[imanghafoori1]

I know it is a new way of thinking and looks weird for you but the whole propose of OOP is to provide such a way of programming.
But this is not the end of story...
There is a rule in oop design that says:

• In most of cases private properties (and methods) should end up being extracted into a new dedicated class as public properties and that new class should be injected into the current one.

So if I continue to work on this and apply Single Responsibility Principle on it...
Of course this class should be broken it to smaller ones each with just a single responsibility and clean intent.
The strategy pattern seems to be a good candidate to for the case of this package.

Any way, that private property causes no harm.

[imanghafoori1]

I do like to spend my weekend refactoring this package if you agree...

[andrewelkins]

I like this. I'll think it over today and may merge it tomorrow.

[imanghafoori1]

The strategy of making the filer name is all gathered here.