use laravel Event Listeners for clearing cache #429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This does bring up the question - why is this flushing all cached roles instead of just the specific user's? and why isn't it clearing the cache on |
This was referenced Nov 27, 2015
imnotjames
changed the title
Collaborator
|
Looks good. I'll merge tomorrow |
|
👍 Implementation looks good. I definitely like that this simplifies the code by overloading fewer methods. |
Contributor
Author
|
So it looks like a different method to resolve this has been chosen which adds in extra code around all of this in #532. @andrewelkins Should I bother correcting the conflicts at this point? |
Contributor
Author
|
@andrewelkins I've updated this to be against the latest codebase |
rhwilr
pushed a commit
to SocietyCMS/Core
that referenced
this pull request
May 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the Laravel Model Event Listeners to handle the flushing of the cache for roles.
This should resolve issue #428