Fixes Issue #352 #700
Merged
Fixes Issue #352 #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue Zizaco#352: Undefined index: id during attachPermission using array Zizaco#352 Traits\EntrustRoleTrait:173 in attachPermission When input is determined to be an array, the function incorrectly attempts to get the value of the 'id' attribute instead of processing a list of Roles. Fix calls attachPermissions on $permission instead, giving the desired functionality. Traits\EntrustRoleTrait:192 in detachPermission See above. Refactors Traits\EntrustRoleTrait:detachPermission to follow coding standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #352: Undefined index: id during attachPermission using array
Traits\EntrustRoleTrait:173 in attachPermission
When input is determined to be an array, the function incorrectly attempts
to get the value of the 'id' attribute instead of processing a list of
Roles. Fix calls attachPermissions on $permission instead, giving the
desired functionality.
Traits\EntrustRoleTrait:192 in detachPermission
See above.
Refactors Traits\EntrustRoleTrait:detachPermission to follow coding standard