Update EntrustPermissionTrait.php #994
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve type hinting, naming, and readability: - Added return types: BelongsToMany for roles(), void for boot method - Renamed boot() to bootEntrustPermissionTrait to avoid trait conflicts - Replaced sync([]) with detach() for clarity - Removed unnecessary return true in event listener - Added import for BelongsToMany - Improved formatting and line breaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Improvements
boot()tobootEntrustPermissionTrait()to prevent trait conflictssync([])withdetach()for better clarity and intentreturn truefrom model event listenerBelongsToManyfor better readabilityAll changes are non-breaking and maintain the original behavior.