Add Wake/Sleep/Reset to PTZ functions (credit: @sctt)

[sctt]

Hello,

i can't find anywhere the control functions named "Wake", "Sleep" and "Reset" that are present in the classic zoneminder web interface.

are they actually missing or am i missing something?

thank you.

[pliablepixels]

You mean PTZ functions? They are not implemented yet in zmNinja

[sctt]

Yes, i mean PTZ functions.

You say that they are not implemented yet, but that confuses me because i can see a PTZ panel which i can use to control movement functions.

I use Wake and Sleep functions to control my IR LEDs, but i can temporarily use movement functions for that aim, even if it is quite counterintuitive.

While waiting for those Wake and Sleep functions to be implemented, can you please confirm that PTZ movement functions on zmninja have already been coded?

thank you a lot.

[pliablepixels]

not sure which PTZ panel you are referring to - that of ZM or zmNinja. zmNinja has a PTZ panel, but I haven't added buttons beyond movement and presets. I don't have a camera to test wake/sleep

PTZ movement has been implemented in zmNinja. You can always download the desktop version which is free and test for yourself to make sure it works for you.

[sctt]

I was referring to zmNinja panel.

Thank you for your answer, i see that only movement functions have been implemented on zmNinja, and i can use those to control my IR LEDs right now.

Anyway, you don't need special cameras to test wake/sleep/reset or anything.
Since camera control in zoneminder is achieved by custom perl scripts, you can just modify your own in order to move your camera on wake, sleep or reset commands.
That will assure you that the integration with APIs is working, i don't think you need anything else for this task.

That was just a suggestion if you really intend to implement those new buttons, i think that they will be useful to many users.

Thank you again for your support.

[pliablepixels]

No, that won't help. All that does is simply add a button called wake that just moves the camera which really doesn't help in testing if zmNinja got the wake command right.

[sctt]

Sorry, i don't really want to insist, but i took a look at your code...

on the click event of your zmNinja PTZ panel buttons you just call a ControlPTZ function with the proper cmd name.

controlPTZ($scope.monitorId, $scope.ptzMoveCommand + 'DownLeft');

that function just posts HTTP data to zoneminder in this simple format:

request=control&user=bla&passwd=bla&id=4&control=moveConLeft

i see that your code doesn't really care what the control command actually does, it just invoke it by posting the command name to ZM.

to implement a wake function you just need to do something like this:

controlPTZ($scope.monitorId, $scope.ptzWakeCommand);

posting those data:

request=control&user=bla&passwd=bla&id=4&control=wake

for what concerns to you, that wake function could do anything, from turning on IR LEDs to moving your camera orientation, from echoing an 'hello world' on a /tmp/test file to activating your house self exploding bombs... the effect is not important at all, it depends on the custom perl script which is a user responsability.

i don't want to sound like imposing this implementation to you, i will be happy to code it by myself in the next future, when i will manage to overcome those deathlines which i'm currently on.

if i'll find the time to code and test this enhancement, i hope you will consider it for your next release.

thank you.

[pliablepixels]

Happy to accept a PR, here are the things you need to do:

1. Before you add the button for wake and sleep, make sure you check for CanWake and CanSleep in the controlDB - the buttons should show up only if this is 1
2. I'd really prefer you test it with the wake and sleep functions of a camera that supports it. I know you are suggesting one can easily fake it with a different backend routine for sub wake() for a control script, but the problem is the moment I introduce it, people will expect it to work - I Don't want to add a feature I've stubbed in the backend with some other command. So if you have a ZM instance with wake and sleep working via a control script, please test it against that camera

[sctt]

Got it, thanks a lot.
Sure i'll let you know about this.
see ya!