Saving event server settings is erratic + push received for monitors that are unchecked

[mateuszdrab]

Hi

First of all, huge thanks for making this app! I've purchased it on Android and also use it on my PC. Best front end for ZM.

Today, I've configured the event server and shortly discovered two separate issues (or maybe one). Would appreciate if you can confirm this is a bug but it seems so for me.

Issue 1
The notifications are working, however, I get notifications for all monitors after making any additional setting change and saving.

Let's say we have monitors with IDs: 1,2,3,4

Steps to reproduce issue 1:

• select monitor 1 and 3 and enable event server in zmNinja
• logs on zoneminder reflect that monitor 1 and 3 are enabled
• go back to settings and select monitor 2, save
• logs on server indicate monitors 1, 2 and 3 enabled, then another set of repetitive events indicated monitors 1,2,3 and 4 enabled.
• in order to enable monitor 1 and 3, I have to disable the event server in the configuration and enable it again.

Issue 2
After saving event server settings (changing monitors to get push notifications for), configuration gets sent to the server. After closing the app and reopening, the selected monitor isn't shown as selected. This can be avoided by clicking save on events server page followed by clicking save on the server settings page.

Steps to reproduce issue 2:

• go to event server config page, toggle an existing monitor then click save.
• close the app from task manager and reopen it, go back to the settings
• event server settings do not reflect the changed setting even though at this time, the server would have the new config as that gets sent after clicking save

Here is an extract from the log in the production system

Target monlist = 5,3,8
Achieved monlist in /etc/private/tokens.txt: 5,3,1,2,4,6,9,8

2017-03-20 22:02:25.563670 zmeventnotification 22522 INF Pushproxy registration success zmeventnotification.pl
2017-03-20 22:02:25.345620 zmeventnotification 22522 INF overwriting (token) monlist with:5,3,1,2,4,6,9,8 zmeventnotification.pl
2017-03-20 22:02:25.345290 zmeventnotification 22522 INF token (token) matched, previously stored monlist is: 5,3,8 zmeventnotification.pl
2017-03-20 22:02:25.344580 zmeventnotification 22522 INF SaveTokens called with:monlist=5,3,1,2,4,6,9,8, intlist=0,0,0,0,0,0,0,0, platform=android, push=enabled zmeventnotification.pl
2017-03-20 22:02:25.343450 zmeventnotification 22522 INF Storing token ...ZEt9ohpPYN,monlist:5,3,1,2,4,6,9,8,intlist:0,0,0,0,0,0,0,0,pushstate:enabled zmeventnotification.pl
2017-03-20 22:02:25.339050 zmeventnotification 22522 INF Pushproxy registration success zmeventnotification.pl
2017-03-20 22:02:25.134830 zmeventnotification 22522 INF overwriting (token) monlist with:5,3,8 zmeventnotification.pl
2017-03-20 22:02:25.134420 zmeventnotification 22522 INF token (token) matched, previously stored monlist is: 5,3,8 zmeventnotification.pl
2017-03-20 22:02:25.133860 zmeventnotification 22522 INF SaveTokens called with:monlist=-1, intlist=-1, platform=android, push=enabled zmeventnotification.pl
2017-03-20 22:02:25.132970 zmeventnotification 22522 INF Storing token ...ZEt9ohpPYN,monlist:-1,intlist:-1,pushstate:enabled zmeventnotification.pl
2017-03-20 22:02:25.122930 zmeventnotification 22522 INF Pushproxy registration success zmeventnotification.pl
2017-03-20 22:02:24.903480 zmeventnotification 22522 INF overwriting (token) monlist with:5,3,8 zmeventnotification.pl
2017-03-20 22:02:24.903160 zmeventnotification 22522 INF token (token) matched, previously stored monlist is: 5,3,1,2,4,6,9,8 zmeventnotification.pl
2017-03-20 22:02:24.902660 zmeventnotification 22522 INF SaveTokens called with:monlist=5,3,8, intlist=5,0,0, platform=android, push=enabled zmeventnotification.pl
2017-03-20 22:02:24.901790 zmeventnotification 22522 INF Contrl: Storing token ...ZEt9ohpPYN,monlist:5,3,8,intlist:5,0,0,pushstate:enabled

Can you please try to reproduce this?

Any more details needed? I'm here to feedback :)

Platform: Android 6.0 Marshmallow
Nature: Bug

Thanks!
Matt

[pliablepixels]

Yes, I can confirm this is a problem and it takes 2 or 3 taps to get things right. That part of the code is really clumsy - I need to get to fixing it :-)

[mateuszdrab]

I'd help, but I'm not sure if I'd be able to understand the code ;)
I better get you to fix it...

[JOrion9999]

I think I have a related issue .. If I go to my ZmNinja settings and enable event monitoring it selects all my cameras .. if I disable the ones I don't want notifications for, it still gives me notifications for all the cameras.

I cant get it to only notify for the cameras I want it to notify on .. no matter how I set it .. it spams notifications for all cameras not just the selected ones ... I have a couple of cameras that are in public areas so if I enable this I get non stop notifications .. I only want some "private" area cameras to notify if there is activity.

[mateuszdrab]

Yup, I still have the same issue :(

[pliablepixels]

There are two issues reported here

1. Saving Event server doesn't work reliably
2. Notifications sent for monitors that are filtered out

They are related, but likely not 100%.

Anyway, I've been chipping away at fixing bad code.

1. Can both of you please send me an email, I'd like you to try a debug android version. You will need to uninstall the existing zmNinja app (pliablepixels AT gmail)

2. Stop the event server

3. Empty out the tokens file (don't delete it) /etc/private/tokens.txt (this is an important step - we don't want old entries confusing things for us)

4. Please make sure you upgrade your event server with the latest master (0.97) https://raw.githubusercontent.com/pliablepixels/zmeventserver/master/zmeventnotification.pl and please make sure it is running properly (this involves first stopping the old version)

5. Keep a logs window on tail -f /var/log/syslog | grep zme

6. Now start the new zmNinja debug build

7. set it up properly, make sure you save the server settings

8. Go to event server settings, set it up

9. Force an alarm, validate that you get the push

10. Now uncheck some monitor and save

11. Validate that in the logs window of zmeventserver you see a message updating the monitor list (the unchecked ids should no longer be there)

12. Force an alarm on the unchecked monitor and validate that you don't get a push

13. Inspect /etc/private/tokens.txt and ensure that the list of monitors exclude your removed monitor (its a comma separated list of numbers right after the large token id.

If you still see notifications for unchecked monitors, I'll need the zmeventserver logs for when that happens.

[pliablepixels]

ZoneMinder/zmeventnotification@f07865e

[pliablepixels]

pliablepixels@ac1cef4