-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feat: New design of the audio stream control slider #4394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@connortechnology |
|
How about instead of importing the entire git repo for nouislider, we only import the dist files, in an appropriately named directory (including version number). It isn't clear to me what this actually gets us and I'm loath to keep including megabytes of js and other stuff just to style a volume input. After a while people start to complain about bloat. We are already bloated. And keeping track of updates and vulernabilities in these dependencies is what is totally destroying my ability to manage a mobile app. We don't need it in the web ui too. But that's my bias. I have asked others to review and give their opinion. |
- Load minified files ".j" and ".css"
Yes, of course, I did it + import minified files. Total weight of files loaded into UI = 33kB. I don't think it's a big volume.
UI, in my opinion, should look beautiful, convenient and functional.
There are no megabytes, there are several kilobytes of useful files.
The slider does not use any dependencies and it is written in vanilla JS. I do not like various frameworks and try to use JQuery as little as possible. What mobile app are you talking about? About zmNinja? I do not want to inconvenience you, but I want to have a beautiful, convenient ZM and at the same time not have problems with further code support.
It's your right, if you don't want to use this slider - you can just close this PR.
Ok, let's wait and see what the others have to say. |
|
One of the important advantages - Fully synchronizes with volume changes (including mute) using the browser's system player. |
|
@connortechnology |
…ream may not yet exist (MonitorStream.js)
…ream may not yet exist (MonitorStream.js)
|
@connortechnology |

Now it looks like this:


Advantages: