-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix: After the cursor leaves Thumbs, ZMS must always be stopped, even in case of network problems. #4430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Next we will use this attribute to stop the ZMS process after the cursor leaves the image by sending the CMD_QUIT command.
… can send ZMS the CMD_QUIT command without using MonitorStream. (monitor.php)
… can send ZMS the CMD_QUIT command without using MonitorStream. (console.php)
Here adding the attribute is not necessary, because when hovering the cursor ZMS does not start at the moment. I added it for consistency. It will not make things worse.
… can send ZMS the CMD_QUIT command without using MonitorStream. (watch.php)
|
That isn't going to do it. We need a keepalive. The zms cgi needs a keepalive parameter, so that if it doesn't get a status update request after so many seconds, it dies. We can't depend on CMD_QUIT. |
Why? It works fine for me! I'm debugging JS now.
Yeah, I agree. That would be a great option. But I don't know how to do it :(
Yeah, but it's better than relying on SIGPIPE alone |
|
This PR works! |
|
@connortechnology |
For all Thumbs we will assign the attribute "data-monitor-url" so that we can send ZMS the CMD_QUIT command without using MonitorStream.
We should not rely only on SIGPIPE, we must terminate ZMS correctly in any case.
Closed #4418