feat: estimated sgho rewards #2636
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds estimated weekly rewards functionality to the sGHO staking interface, providing users with a clear view of their expected weekly rewards based on their current balance and APR.
- Adds a new "Weekly Rewards" panel to display estimated weekly earnings
- Introduces NumberFlow animation library for smooth number transitions
- Updates error code from 1 to 2455 in the AddressBlockedModal component
Reviewed Changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/modules/sGho/SGhoHeader.tsx | Implements weekly rewards calculation and display with NumberFlow animation |
| src/locales/en/messages.po | Adds translation entries for weekly rewards tooltip and updates error code |
| src/components/AddressBlockedModal.tsx | Updates error code from 1 to 2455 |
| package.json | Adds @number-flow/react dependency for animated number display |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| const downToSM = useMediaQuery(theme.breakpoints.down('sm')); | ||
|
|
||
| const stakeUserData = stakeUserResult?.[0]; |
There was a problem hiding this comment.
should we check stakeUserResult len to avoid null pointers
There was a problem hiding this comment.
we are using it in other places as well will keep it consistent for now
src/modules/sGho/SGhoHeader.tsx
Outdated
| const aprDecimal = stakeAPR?.apr ? parseFloat(stakeAPR.apr) : 0; | ||
| const weeklyRewardsEstimate = (parseFloat(userSGhoBalanceFormatted) * aprDecimal) / 52; |
There was a problem hiding this comment.
yeah good catch 4f92277
| > | ||
| {parseFloat(userSGhoBalanceFormatted) > 0 ? ( | ||
| <Stack direction="row" alignItems="baseline" spacing={0.5}> | ||
| <NumberFlow |
Co-authored-by: Copilot <[email protected]>
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.43 MB (🟡 +4.62 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Sixteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
60.74 KB (🟡 +1.15 KB) |
1.49 MB |
/404 |
2.79 KB (🟡 +327 B) |
1.43 MB |
/500 |
3.19 KB (🟡 +283 B) |
1.43 MB |
/bridge |
33.75 KB (🟡 +309 B) |
1.46 MB |
/dashboard |
51.89 KB (🟡 +952 B) |
1.48 MB |
/faucet |
15.21 KB (🟡 +309 B) |
1.44 MB |
/governance |
80.81 KB (🟡 +196 B) |
1.51 MB |
/governance/ipfs-preview |
100.63 KB (🟡 +965 B) |
1.53 MB |
/governance/v3/proposal |
122.85 KB (🟡 +109 B) |
1.55 MB |
/history |
24.04 KB (🟡 +311 B) |
1.45 MB |
/markets |
35.91 KB (🟡 +2.29 KB) |
1.46 MB |
/reserve-overview |
23.3 KB (🟡 +289 B) |
1.45 MB |
/safety-module |
37.37 KB (🟡 +346 B) |
1.47 MB |
/sgho |
85.17 KB (🟡 +6.21 KB) |
1.51 MB |
/staking |
32.11 KB (🟡 +309 B) |
1.46 MB |
/v3-migration |
35.51 KB (🟡 +311 B) |
1.46 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
1.43 MB (🟡 +4.62 KB) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Sixteen Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
| Page | Size (compressed) | First Load |
|---|---|---|
/ |
60.74 KB (🟡 +1.15 KB) |
1.49 MB |
/404 |
2.79 KB (🟡 +327 B) |
1.43 MB |
/500 |
3.19 KB (🟡 +283 B) |
1.43 MB |
/bridge |
33.75 KB (🟡 +309 B) |
1.46 MB |
/dashboard |
51.89 KB (🟡 +952 B) |
1.48 MB |
/faucet |
15.21 KB (🟡 +309 B) |
1.44 MB |
/governance |
80.81 KB (🟡 +196 B) |
1.51 MB |
/governance/ipfs-preview |
100.63 KB (🟡 +965 B) |
1.53 MB |
/governance/v3/proposal |
122.85 KB (🟡 +109 B) |
1.55 MB |
/history |
24.04 KB (🟡 +311 B) |
1.45 MB |
/markets |
35.91 KB (🟡 +2.29 KB) |
1.46 MB |
/reserve-overview |
23.3 KB (🟡 +289 B) |
1.45 MB |
/safety-module |
37.37 KB (🟡 +346 B) |
1.47 MB |
/sgho |
85.22 KB (🟡 +6.25 KB) |
1.51 MB |
/staking |
32.11 KB (🟡 +309 B) |
1.46 MB |
/v3-migration |
35.51 KB (🟡 +311 B) |
1.46 MB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
📦 Next.js Bundle Analysis for aave-uiThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files