Conversation
JonoYang
force-pushed
the
package-field-update-method
branch
2 times, most recently
from
6937b44 to
db673ea
Compare
Member
keshav-space
left a comment
keshav-space
left a comment
There was a problem hiding this comment.
Thanks @JonoYang
I was wondering, do we really need both update_field and update_fields? Isn't update_fields sufficient?
Member
Author
|
@keshav-space That's true. I have the two because I wasn't sure what the best way to have the method arguments for updating a single field or multiple fields. I've removed |
Signed-off-by: Jono Yang <jyang@nexb.com>
* Update test expectations Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Remove _update_field and update_field Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
package-field-update-method
branch
from
9d47b09 to
60c5996
Compare
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new method to the Package model to update fields. The idea is that we use these methods to update package fields, where it also updates the history as well.